Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make xportr_type() drop factor levels #181

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Conversation

EeethB
Copy link
Collaborator

@EeethB EeethB commented Sep 6, 2023

Changes Description

Adds a single line to xportr_type() that makes it drop the levels attribute of a factor column when the type is changed

Closes #159

Task List

  • The spirit of xportr is met in your Pull Request
  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Summary of changes filled out in the above Changes Description. Can be removed or left blank if changes are minor/self-explanatory.
  • Check that your Pull Request is targeting the devel branch, Pull Requests to main should use the Release Pull Request Template
  • Code is formatted according to the tidyverse style guide. Use styler package and functions to style files accordingly.
  • Updated relevant unit tests or have written new unit tests. See our Wiki for conventions used in this package.
  • Creation/updated relevant roxygen headers and examples. See our Wiki for conventions used in this package.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Run pkgdown::build_site() and check that all affected examples are displayed correctly and that all new/updated functions occur on the "Reference" page.
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Address any updates needed for vignettes and/or templates
  • Link the issue Development Panel so that it closes after successful merging.
  • Fix merge conflicts
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6ccbc1d) 100.00% compared to head (cd65f02) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #181   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          580       581    +1     
=========================================
+ Hits           580       581    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EeethB EeethB marked this pull request as ready for review November 28, 2023 18:18
@EeethB EeethB merged commit 582aa27 into main Nov 28, 2023
13 checks passed
@EeethB EeethB deleted the 159_bug_type_factor_levels branch November 28, 2023 18:18
@bms63
Copy link
Collaborator

bms63 commented Nov 28, 2023

@EeethB really should have a review before you merge in -

I think we should add tests to make sure this works

@elimillera

@EeethB
Copy link
Collaborator Author

EeethB commented Nov 28, 2023

That's a good point, I added a test for it. I will open a new PR

elimillera added a commit that referenced this pull request Dec 7, 2023
Closes #159 - Re-opening #181 to add a test and get review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: xportr_type() retains factor levels
2 participants